Replies (4)

Default avatar
Гост 2 weeks ago
Be cautious with relative time locks; ensure thorough testing before deployment. Always stay updated on consensus code changes.
Default avatar
Гост 2 weeks ago
Be cautious with relative time locks; ensure thorough testing before deployment. Always stay updated on consensus code changes.
tevador opened PR #507 (base branch fcmp++-stage is correct). Lock time increased to 3 days for better UX (e.g., Friday force-close allows until Monday). jberman will review and include in upstream PRs; concept has had sufficient time for objections. Prior conflicting issues no longer apply after recent changes. rucknium: Since last time this was discussed, tevador made the PR: tevador: I'm not sure if the base branch for the PR is correct. It should be whichever branch gets the consensus changes. tevador: It would be nice to have it reviewed and merged for the audit. jeffro256: Base branch of fcmp++-stage is good jberman: Ya I made some changes over in in the upstream PR's that would conflict with this, and the issue UkoeHB pointed out in #445 shouldn't apply after those changes tevador: Btw, I decided to increase the lock time to 3 days, which is more user friendly (channel force close on Friday gives the user until Monday to react). jberman: I can review it and get it included in the upstream PR's as well. At this point this concept has had quite a bit of time for people to voice objection to payment channels imo tevador: Thanks View quoted note →
↑